Skip to content

GitLab

Switch branch/tag
History Find file
Clone
[PATCH] Let WARN_ON/WARN_ON_ONCE return the condition
Herbert Xu authored 

Letting WARN_ON/WARN_ON_ONCE return the condition means that you could do

if (WARN_ON(blah)) {
	handle_impossible_case
}

Rather than

if (unlikely(blah)) {
	WARN_ON(1)
	handle_impossible_case
}

I checked all the newly added WARN_ON_ONCE users and none of them test the
return status so we can still change it.

[akpm@osdl.org: warning fix]
[akpm@osdl.org: build fix]
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
684f9783
Name Last commit Last update
..
acpi Pull acpi_os_allocate into test branch
asm-alpha [PATCH] Standardize pxx_page macros
asm-arm Merge branch 'devel' of master.kernel.org:/home/rmk/linux-2.6-arm
asm-arm26 [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-avr32 [PATCH] AVR32 MTD: Static Memory Controller driver
asm-cris [PATCH] Standardize pxx_page macros
asm-frv [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-generic [PATCH] Let WARN_ON/WARN_ON_ONCE return the condition
asm-h8300 [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-i386 [PATCH] convert i386 Summit subarch to use SRAT info for apicid_to_node calls
asm-ia64 Merge branch 'release' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux-2.6
asm-m32r [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-m68k [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-m68knommu [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-mips [MIPS] s/__ASSEMBLER__/__ASSEMBLY__/ for clarity sake.
asm-parisc [PATCH] Standardize pxx_page macros
asm-powerpc [PATCH] Let WARN_ON/WARN_ON_ONCE return the condition
asm-ppc [PATCH] Standardize pxx_page macros
asm-s390 [PATCH] Make touch_nmi_watchdog imply touch_softlockup_watchdog on all archs
asm-sh Merge master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6
asm-sh64 [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-sparc [PATCH] Standardize pxx_page macros
asm-sparc64 [PATCH] Standardize pxx_page macros
asm-um [PATCH] uml: remove pte_mkexec
asm-v850 [PATCH] consistently use MAX_ERRNO in __syscall_return
asm-x86_64
asm-xtensa
crypto
keys
linux
math-emu
media
mtd
net
pcmcia
rdma
rxrpc
scsi
sound
video
Kbuild