Skip to content

GitLab

Switch branch/tag
History Find file
Clone
SUNRPC: Avoid return code checking in rpcbind XDR encoder functions
Chuck Lever authored 

Clean up.

The trend in the other XDR encoder functions is to BUG() when encoding
problems occur, since a problem here is always due to a local coding
error.  Then, instead of a status, zero is unconditionally returned.

Update the rpcbind XDR encoders to behave this way.

To finish the update, use the new-style be32_to_cpup() and
cpu_to_be32() macros, and compute the buffer sizes using raw integers
instead of sizeof().  This matches the conventions used in other XDR
functions.
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Tested-by: default avatarJ. Bruce Fields <bfields@redhat.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
4129ccf3
Name Last commit Last update
..
auth_gss Merge branch 'for-2.6.37' of git://linux-nfs.org/~bfields/linux
xprtrdma sunrpc/xprtrdma: clean up workqueue usage
Kconfig nfsd4: remove spkm3
Makefile SUNRPC: Provide functions for managing universal addresses
addr.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
auth.c Merge branch 'for-2.6.37' of git://linux-nfs.org/~bfields/linux
auth_generic.c sunrpc: fix up rpcauth_remove_module section mismatch
auth_null.c SUNRPC: Move the bound cred to struct rpc_rqst
auth_unix.c SUNRPC: Move the bound cred to struct rpc_rqst
backchannel_rqst.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
bc_svc.c Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6
cache.c Merge branch 'for-2.6.37' of git://linux-nfs.org/~bfields/linux
clnt.c SUNRPC: Fix an infinite loop in call_refresh/call_refreshresult
netns.h sunrpc: Make the ip_map_cache be per-net
rpc_pipe.c convert get_sb_single() users
rpcb_clnt.c SUNRPC: Avoid return code checking in rpcbind XDR encoder functions
sched.c Merge branch 'nfs-for-2.6.37' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6
socklib.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
stats.c SUNRPC: Simplify rpc_alloc_iostats by removing pointless local variable
sunrpc.h nfsd41: sunrpc: Added rpc server-side backchannel handling
sunrpc_syms.c sunrpc: Make the ip_map_cache be per-net
svc.c sunrpc: close connection when a request is irretrievably lost.
svc_xprt.c sunrpc: prevent use-after-free on clearing XPT_BUSY
svcauth.c net: Move && and || to end of previous line
svcauth_unix.c sunrpc: Use helper to set v4 mapped addr in ip_map_parse
svcsock.c
sysctl.c
timer.c
xdr.c
xprt.c
xprtsock.c