Skip to content

GitLab

Switch branch/tag
History Find file
Clone
serial: mrst_max3110: initialize waitqueue earlier
Mika Westerberg authored 

The driver went to initialize its waitqueue at the start of the main
processing thread.  However, it is possible that this thread is not
scheduled on a CPU before the write function is called which leads to a
following error:

  BUG: spinlock bad magic on CPU#1, swapper/1
   lock: f5f3ebdc, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
  Pid: 1, comm: swapper Not tainted 3.0.0-rc2+ #67
  Call Trace:
   [<c1289663>] spin_bug+0xa3/0xf0
   [<c12897ad>] do_raw_spin_lock+0x7d/0x150
   [<c14963de>] _raw_spin_lock_irqsave+0x4e/0x60
   [<c102f2bb>] __wake_up+0x1b/0x50
   [<c12d3715>] serial_m3110_con_write+0x55/0x60
   [<c1041575>] __call_console_drivers+0x75/0x90
   [<c10415d9>] _call_console_drivers+0x49/0x80
   [<c1041baa>] console_unlock+0xca/0x1f0
   [<c10420ef>] vprintk+0x18f/0x4f0
   [<c14928a3>] printk+0x18/0x1a
   [<c1042730>] register_console+0x2e0/0x350
   [<c12d098e>] uart_add_one_port+0x33e/0x3d0
   [<c1485ba6>] serial_m3110_probe+0x1c2/0x1df
   [<c1303db7>] spi_drv_probe+0x17/0x20
   ...

Fix this by initializing the waitqueue before the main thread is
created.
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
33b1e693
Name Last commit Last update
..
hvc Fix common misspellings
ipwireless Merge git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6
serial serial: mrst_max3110: initialize waitqueue earlier
vt Revert "tty: make receive_buf() return the amout of bytes received"
Kconfig n_tracerouter and n_tracesink ldisc additions.
Makefile n_tracerouter and n_tracesink ldisc additions.
amiserial.c tty: remove invalid location line in file header
bfin_jtag_comm.c drivers/tty/bfin_jtag_comm.c: avoid calling put_tty_driver on NULL
cyclades.c Merge branch 'trivial' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6
isicom.c tty: move a number of tty drivers from drivers/char/ to drivers/tty/
moxa.c drivers/tty/moxa.c: Put correct tty value
moxa.h tty: move a number of tty drivers from drivers/char/ to drivers/tty/
mxser.c tty: move a number of tty drivers from drivers/char/ to drivers/tty/
mxser.h Fix common misspellings
n_gsm.c Revert "tty: make receive_buf() return the amout of bytes received"
n_hdlc.c Revert "tty: make receive_buf() return the amout of bytes received"
n_r3964.c Revert "tty: make receive_buf() return the amout of bytes received"
n_tracerouter.c n_tracerouter and n_tracesink ldisc additions.
n_tracesink.c n_tracerouter and n_tracesink ldisc additions.
n_tracesink.h n_tracerouter and n_tracesink ldisc additions.
n_tty.c Revert "tty: make receive_buf() return the amout of bytes received"
nozomi.c Merge branch 'trivial' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6
pty.c tty: remove invalid location line in file header
rocket.c TTY: rocket, remove unused variables
rocket.h tty: move a number of tty drivers from drivers/char/ to drivers/tty/
rocket_int.h
synclink.c
synclink_gt.c
synclinkmp.c
sysrq.c
tty_audit.c
tty_buffer.c
tty_io.c
tty_ioctl.c
tty_ldisc.c
tty_mutex.c
tty_port.c