1. 31 Oct, 2011 1 commit
  2. 19 Oct, 2011 1 commit
  3. 25 Aug, 2011 1 commit
  4. 09 Jun, 2009 1 commit
  5. 26 Jul, 2008 1 commit
  6. 23 Jul, 2008 1 commit
  7. 03 Jun, 2008 1 commit
  8. 27 Apr, 2007 1 commit
  9. 26 Apr, 2007 1 commit
    • Jean Delvare's avatar
      [NET]: Clean up sk_buff walkers. · eefa3906
      Jean Delvare authored
      
      I noticed recently that, in skb_checksum(), "offset" and "start" are
      essentially the same thing and have the same value throughout the
      function, despite being computed differently. Using a single variable
      allows some cleanups and makes the skb_checksum() function smaller,
      more readable, and presumably marginally faster.
      
      We appear to have many other "sk_buff walker" functions built on the
      exact same model, so the cleanup applies to them, too. Here is a list
      of the functions I found to be affected:
      
      net/appletalk/ddp.c:atalk_sum_skb()
      net/core/datagram.c:skb_copy_datagram_iovec()
      net/core/datagram.c:skb_copy_and_csum_datagram()
      net/core/skbuff.c:skb_copy_bits()
      net/core/skbuff.c:skb_store_bits()
      net/core/skbuff.c:skb_checksum()
      net/core/skbuff.c:skb_copy_and_csum_bit()
      net/core/user_dma.c:dma_skb_copy_datagram_iovec()
      net/xfrm/xfrm_algo.c:skb_icv_walk()
      net/xfrm/xfrm_algo.c:skb_to_sgvec()
      
      OTOH, I admit I'm a bit surprised, the cleanup is rather obvious so I'm
      really wondering if I am missing something. Can anyone please comment
      on this?
      Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      eefa3906
  10. 11 Feb, 2007 1 commit
  11. 21 Jul, 2006 1 commit
  12. 18 Jun, 2006 2 commits