Skip to content

GitLab

Switch branch/tag
  1. 14 Jan, 2008 1 commit
    • Oleg Nesterov's avatar
      fix the "remove task_ppid_nr_ns" commit · a98fdcef
      Oleg Nesterov authored 
      Commit 84427eae

 (remove task_ppid_nr_ns)
moved the task_tgid_nr_ns(task->real_parent) outside of lock_task_sighand().
This is wrong, ->real_parent could be freed/reused.

Both ->parent/real_parent point to nothing after __exit_signal() because
we remove the child from ->children list, and thus the child can't be
reparented when its parent exits.

rcu_read_lock() protects ->parent/real_parent, but _only_ if we know it was
valid before we take rcu lock.

Revert this part of the patch.
Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a98fdcef
  3. 13 Jan, 2008 1 commit
    • Roland McGrath's avatar
      remove task_ppid_nr_ns · 84427eae
      Roland McGrath authored 
      
task_ppid_nr_ns is called in three places.  One of these should never
have called it.  In the other two, using it broke the existing
semantics.  This was presumably accidental.  If the function had not
been there, it would have been much more obvious to the eye that those
patches were changing the behavior.  We don't need this function.

In task_state, the pid of the ptracer is not the ppid of the ptracer.

In do_task_stat, ppid is the tgid of the real_parent, not its pid.
I also moved the call outside of lock_task_sighand, since it doesn't
need it.

In sys_getppid, ppid is the tgid of the real_parent, not its pid.
Signed-off-by: default avatarRoland McGrath <roland@redhat.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      84427eae
  5. 06 Dec, 2007 1 commit
  7. 26 Nov, 2007 1 commit
  9. 29 Oct, 2007 2 commits
  11. 19 Oct, 2007 4 commits
  13. 15 Oct, 2007 1 commit
  15. 23 Aug, 2007 1 commit
  17. 16 Jul, 2007 4 commits
  19. 09 Jul, 2007 2 commits
  21. 08 May, 2007 1 commit
    • William Cohen's avatar
      reduce size of task_struct on 64-bit machines · 97dc32cd
      William Cohen authored 
      This past week I was playing around with that pahole tool
(http://oops.ghostprotocols.net:81/acme/dwarves/

) and looking at the size
of various struct in the kernel.  I was surprised by the size of the
task_struct on x86_64, approaching 4K.  I looked through the fields in
task_struct and found that a number of them were declared as "unsigned
long" rather than "unsigned int" despite them appearing okay as 32-bit
sized fields.  On x86_64 "unsigned long" ends up being 8 bytes in size and
forces 8 byte alignment.  Is there a reason there a reason they are
"unsigned long"?

The patch below drops the size of the struct from 3808 bytes (60 64-byte
cachelines) to 3760 bytes (59 64-byte cachelines).  A couple other fields
in the task struct take a signficant amount of space:

struct thread_struct       thread;               688
struct held_lock           held_locks[30];       1680

CONFIG_LOCKDEP is turned on in the .config

[akpm@linux-foundation.org: fix printk warnings]
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      97dc32cd
  23. 12 Feb, 2007 1 commit
  25. 08 Dec, 2006 2 commits
  27. 02 Oct, 2006 3 commits
  29. 29 Sep, 2006 1 commit
  31. 15 Jul, 2006 1 commit
  33. 30 Jun, 2006 1 commit
  35. 26 Mar, 2006 1 commit
  37. 10 Jan, 2006 1 commit
  39. 06 Jan, 2006 1 commit
  41. 30 Oct, 2005 1 commit
    • Hugh Dickins's avatar
      [PATCH] mm: rss = file_rss + anon_rss · 4294621f
      Hugh Dickins authored 
      
I was lazy when we added anon_rss, and chose to change as few places as
possible.  So currently each anonymous page has to be counted twice, in rss
and in anon_rss.  Which won't be so good if those are atomic counts in some
configurations.

Change that around: keep file_rss and anon_rss separately, and add them
together (with get_mm_rss macro) when the total is needed - reading two
atomics is much cheaper than updating two atomics.  And update anon_rss
upfront, typically in memory.c, not tucked away in page_add_anon_rmap.
Signed-off-by: default avatarHugh Dickins <hugh@veritas.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
      4294621f
  43. 17 Sep, 2005 1 commit
  45. 09 Sep, 2005 1 commit
  47. 16 Apr, 2005 1 commit
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored 
      Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.

Let it rip!
      1da177e4