Skip to content

GitLab

Switch branch/tag
  1. 01 Mar, 2010 1 commit
  3. 24 Dec, 2009 1 commit
  5. 09 Dec, 2009 3 commits
  7. 18 Jun, 2009 1 commit
    • Bjorn Helgaas's avatar
      ACPI: asus-acpi: use .notify method instead of installing handler directly · 352fa202
      Bjorn Helgaas authored 
      
This patch adds a .notify() method.  The presence of .notify() causes
Linux/ACPI to manage event handlers and notify handlers on our behalf,
so we don't have to install and remove them ourselves.

This driver relies on seeing system notify events, not device-specific
ones (because it used ACPI_SYSTEM_NOTIFY).  We use the
ACPI_DRIVER_ALL_NOTIFY_EVENTS driver flag to request all events, then
just ignore any device events we get.
Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
CC: Corentin Chary <corentincj@iksaif.net>
CC: Karol Kozimor <sziwan@users.sourceforge.net>
CC: acpi4asus-user@lists.sourceforge.net
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      352fa202
  9. 30 Mar, 2009 1 commit
    • Alexey Dobriyan's avatar
      proc 2/2: remove struct proc_dir_entry::owner · 99b76233
      Alexey Dobriyan authored 
      Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzill...
      99b76233
  11. 20 Jan, 2009 1 commit
  13. 19 Dec, 2008 1 commit
  15. 17 Oct, 2008 2 commits
  17. 11 Oct, 2008 1 commit
  19. 10 Oct, 2008 1 commit
  21. 01 Aug, 2008 1 commit
  23. 18 Mar, 2008 1 commit
  25. 07 Feb, 2008 1 commit
  27. 23 Aug, 2007 1 commit
    • Len Brown's avatar
      ACPI: Schedule /proc/acpi/event for removal · 14e04fb3
      Len Brown authored 
      
Schedule /proc/acpi/event for removal in 6 months.

Re-name acpi_bus_generate_event() to acpi_bus_generate_proc_event()
to make sure there is no confusion that it is for /proc/acpi/event only.

Add CONFIG_ACPI_PROC_EVENT to allow removal of /proc/acpi/event.
There is no functional change if CONFIG_ACPI_PROC_EVENT=y
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      14e04fb3
  29. 03 Aug, 2007 1 commit
  31. 23 Jul, 2007 1 commit
  33. 01 Jul, 2007 1 commit
    • Maxime Austruy's avatar
      asus_acpi: fix oops on non-asus machines · 5ebffd7c
      Maxime Austruy authored 
      
If asus_acpi_init doesn't find any device it knows about, it mistakenly
returns a "success" error code even though it cleans up after itself.  Later
when trying to rmmod asus_acpi, the module_exit routine would try to clean up
one more time and we would end up calling
acpi_bus_unregister_driver(&asus_hotk_driver) twice.  This patch addresses
this first problem by returning -ENODEV when no appropriate device is found.

Then there was also another bug with the code handling the return value of
backlight_device_register.  If this function ever failed, the driver would
cleanup by calling the module_exit routine from module_init, but it would
still return "success".  So any attempt to rmmod this module would result in
asus_acpi_exit being called twice but it's not ready to handle it (I haven't
hit this bug, just found it by code inspection).  This patch fixes that by
inserting a return -ENODEV; at the end of this error handling path.
Signed-off-by: default avatarMaxime Austruy <maxime@tralhalla.org>
Cc: Len Brown <lenb@kernel.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Jan Engelhardt <jengelh@computergmbh.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      5ebffd7c
  35. 20 Jun, 2007 1 commit
  37. 01 Jun, 2007 1 commit
    • Sam Ravnborg's avatar
      acpi: fix section mismatch warning in asus + toshiba · b2b77b23
      Sam Ravnborg authored 
      
Fix following section mismatch warnings in acpi

WARNING: drivers/acpi/asus_acpi.o(.init.text+0xb7): Section mismatch: reference to .exit.text: (after 'init_module')
WARNING: o-i386/drivers/acpi/toshiba_acpi.o(.init.text+0x13a): Section mismatch: reference to .exit.text: (after 'init_module')

The exit function is used in the init function during an error codition.
As __exit may be discarded during link-time / run-time this is no good.
Do not mark the exit function __exit.

Note: This warning is only seen by my local copy of modpost
      but the change will soon hit upstream.
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      b2b77b23
  39. 20 Feb, 2007 2 commits
  41. 17 Feb, 2007 1 commit
  43. 13 Feb, 2007 1 commit
    • Len Brown's avatar
      ACPI: fix acpi_driver.name usage · c2b6705b
      Len Brown authored 
      
It was erroneously used as a description rather than a name.

ie. turn this:

lenb@se7525gp2:/sys> ls bus/acpi/drivers
ACPI AC Adapter Driver  ACPI Embedded Controller Driver  ACPI Power Resource Driver
ACPI Battery Driver     ACPI Fan Driver                  ACPI Processor Driver
ACPI Button Driver      ACPI PCI Interrupt Link Driver   ACPI Thermal Zone Driver
ACPI container driver   ACPI PCI Root Bridge Driver      hpet

into this:

lenb@se7525gp2:~> ls /sys/bus/acpi/drivers
ac  battery  button  container  ec  fan  hpet  pci_link  pci_root  power  processor  thermal
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      c2b6705b
  45. 09 Feb, 2007 1 commit
  47. 03 Feb, 2007 1 commit
  49. 20 Dec, 2006 2 commits
  51. 21 Oct, 2006 1 commit
  53. 14 Oct, 2006 4 commits
  55. 01 Jul, 2006 5 commits