Skip to content

GitLab

Switch branch/tag
  1. 23 Oct, 2009 1 commit
    • Terry Loftin's avatar
      nfs: Panic when commit fails · a8b40bc7
      Terry Loftin authored 
      
Actually pass the NFS_FILE_SYNC option to the server to avoid a
Panic in nfs_direct_write_complete() when a commit fails.

At the end of an nfs write, if the nfs commit fails, all the writes
will be rescheduled.  They are supposed to be rescheduled as NFS_FILE_SYNC
writes, but the rpc_task structure is not completely intialized and so
the option is not passed.  When the rescheduled writes complete, the
return indicates that they are NFS_UNSTABLE and we try to do another
commit.  This leads to a Panic because the commit data structure pointer
was set to null in the initial (failed) commit attempt.
Signed-off-by: default avatarTerry Loftin <terry.loftin@hp.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      a8b40bc7
  3. 19 Aug, 2009 1 commit
  5. 12 Aug, 2009 1 commit
  7. 17 Jun, 2009 3 commits
  9. 09 Jul, 2008 1 commit
  11. 19 Apr, 2008 3 commits
  13. 26 Feb, 2008 2 commits
    • Trond Myklebust's avatar
      NFS: Ensure that the asynchronous RPC calls complete on nfsiod. · 101070ca
      Trond Myklebust authored 
      
We want to ensure that rpc_call_ops that involve mntput() are run on nfsiod
rather than on rpciod, so that they don't deadlock when the resulting
umount calls rpc_shutdown_client(). Hence we specify that read, write and
commit calls must complete on nfsiod.
Ditto for NFSv4 open, lock, locku and close asynchronous calls.
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      101070ca
    • Trond Myklebust's avatar
      NFS: Fix a deadlock with lazy umount · 383ba719
      Trond Myklebust authored 
      
We can't allow rpc callback functions like task->tk_ops->rpc_call_prepare()
and task->tk_ops->rpc_call_done() to call mntput() in any way, since
that will cause a deadlock when the call to rpc_shutdown_client() attempts
to wait on 'task' to complete.

We can avoid the above deadlock by moving calls to mntput to
task->tk_ops->rpc_release() callback, since at that time the task will be
marked as completed, and so rpc_shutdown_client won't attempt to wait on
it.
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      383ba719
  15. 30 Jan, 2008 5 commits
  17. 12 Dec, 2007 1 commit
    • Trond Myklebust's avatar
      Revert "NFS: Ensure we return zero if applications attempt to write zero bytes" · a5576cfa
      Trond Myklebust authored 
      This reverts commit b9148c6b.

On Wed, 12 Dec 2007 10:57:30 -0500, Chuck Lever wrote
> commit b9148c6b should be reverted.  It was recently forward-ported
> from some years-old patches, and is clearly not needed now.
>
> On Dec 11, 2007, at 5:21 PM, Adrian Bunk wrote:
>
>> This code became dead after commit
>> b9148c6b


>> (which BTW doesn't seem to have changed any behaviour) and can
>> therefore
>> be removed.
>>
>> Spotted by the Coverity checker.
>>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>>
>> ---
>> --- linux-2.6/fs/nfs/direct.c.old     2007-12-02 21:54:53.000000000 +0100
>> +++ linux-2.6/fs/nfs/direct.c 2007-12-02 21:55:10.000000000 +0100
>> @@ -897,15 +897,12 @@ ssize_t nfs_file_direct_write(struct kio
>>       if (!count)
>>               goto out;       /* return 0 */
>>
>>       retval = -EINVAL;
>>       if ((ssize_t) count < 0)
>>               goto out;
>> -     retval = 0;
>> -     if (!count)
>> -             goto out;
>>
>>       retval = nfs_sync_mapping(mapping);
>>       if (retval)
>>               goto out;
>>
>>       retval = nfs_direct_write(iocb, iov, nr_segs, pos, count);
>>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
      a5576cfa
  19. 06 Dec, 2007 1 commit
  21. 26 Nov, 2007 4 commits
  23. 23 Oct, 2007 1 commit
  25. 09 Oct, 2007 2 commits
  27. 20 Jul, 2007 1 commit
    • Paul Mundt's avatar
      mm: Remove slab destructors from kmem_cache_create(). · 20c2df83
      Paul Mundt authored 
      Slab destructors were no longer supported after Christoph's
c59def9f

 change. They've been
BUGs for both slab and slub, and slob never supported them
either.

This rips out support for the dtor pointer from kmem_cache_create()
completely and fixes up every single callsite in the kernel (there were
about 224, not including the slab allocator definitions themselves,
or the documentation references).
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
      20c2df83
  29. 11 Jul, 2007 3 commits
  31. 30 May, 2007 1 commit
  33. 24 May, 2007 2 commits
  35. 08 May, 2007 1 commit
  37. 01 May, 2007 1 commit
  39. 15 Apr, 2007 1 commit
  41. 03 Feb, 2007 1 commit
  43. 08 Dec, 2006 1 commit
  45. 07 Dec, 2006 2 commits